Always generate MemoryAccessAlignedMask (#1357)

Drivers can use the stronger alignments to vectorize loads/stores. Fix #1356
google · May 22, 2024 · c1ca1b8 · c1ca1b8
1 parent 769daac
commit c1ca1b8
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/lib/SPIRVProducerPass.cpp b/lib/SPIRVProducerPass.cpp
@@ -5608,11 +5608,10 @@ void SPIRVProducerPassImpl::GenerateInstruction(Instruction &I) {
     SPIRVOperandVec Ops;
     Ops << result_type_id << ptr;
 
-    // Align MemoryOperand is required for PhysicalStorageBuffer
-    if (clspv::Option::PhysicalStorageBuffers()) {
-      Ops << spv::MemoryAccessAlignedMask;
-      Ops << static_cast<uint32_t>(LD->getAlign().value());
-    }
+    // Align MemoryOperand helps load vectorization and is required for
+    // PhysicalStorageBuffer
+    Ops << spv::MemoryAccessAlignedMask;
+    Ops << static_cast<uint32_t>(LD->getAlign().value());
 
     RID = addSPIRVInst(spv::OpLoad, Ops);
 
@@ -5666,11 +5665,10 @@ void SPIRVProducerPassImpl::GenerateInstruction(Instruction &I) {
       Ops << ST->getValueOperand();
     }
 
-    // Align MemoryOperand is required for PhysicalStorageBuffer
-    if (clspv::Option::PhysicalStorageBuffers()) {
-      Ops << spv::MemoryAccessAlignedMask;
-      Ops << static_cast<uint32_t>(ST->getAlign().value());
-    }
+    // Align MemoryOperand helps store vectorization and is required for
+    // PhysicalStorageBuffer
+    Ops << spv::MemoryAccessAlignedMask;
+    Ops << static_cast<uint32_t>(ST->getAlign().value());
 
     RID = addSPIRVInst(spv::OpStore, Ops);
     break;