Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack repeated groups recursively #2675

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Sep 17, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1899

Description
Pack repeated groups recursively

Alternative(s) considered
NA

Type
Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 changed the title Fix packing repeated groups Pack repeated groups recursively Nov 5, 2024
@jingtang10 jingtang10 marked this pull request as ready for review November 5, 2024 20:35
@jingtang10 jingtang10 requested a review from a team as a code owner November 5, 2024 20:35
@jingtang10
Copy link
Collaborator Author

@nsabale7 can you please take a look at this PR - also can you pls test if this works in your case now? thanks.

@nsabale7
Copy link
Collaborator

nsabale7 commented Nov 7, 2024

@jingtang10 I tested this PR changes with questionnaire/questionnaireResponse attached in the issue and it works as expected. Looks good for me. Thanks

@jingtang10 jingtang10 enabled auto-merge (squash) November 7, 2024 10:45
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 merged commit 11ed6f0 into google:master Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Repeated Group: Questionnaire Response validator fails if response contains multiple answers
3 participants