New "Promotion" Mode #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
halelidan
commented
Oct 8, 2024
halelidan
commented
- Implement config switching based on promotion flag
- Modify image services to use CONFIG or PROMOTION_CONFIG as appropriate
- Skip asset deletion in promotion mode for ImageExtensionService
- Add new ImagePauseService for pausing uploaded assets
- Implement config switching based on promotion flag - Modify image services to use CONFIG or PROMOTION_CONFIG as appropriate - Skip asset deletion in promotion mode for ImageExtensionService - Add new ImagePauseService for pausing uploaded assets
akushnarov
reviewed
Oct 9, 2024
| } | ||
|
|
||
| export const sheet = | ||
| SpreadsheetApp.getActiveSpreadsheet().getSheetByName('Config')!; | ||
| const DEFAULT_CONFIG = { | ||
| export const promotionSheet = | ||
| SpreadsheetApp.getActiveSpreadsheet().getSheetByName('Promotion_Config')!; |
There was a problem hiding this comment.
I think you can make the setup even more flexible if you use in the main config sheet Promotion Mode Config = <PROMO_CONFIG_SHEET_NAME> (if empty it is equal to Is Promotion Mode = no) instead of Is Promotion Mode = yes|no. In this way you can have several configs for e.g. different promo seasons and quickly switch them.
| .filter(e => e[0]) | ||
| .reduce((res, e) => { | ||
| return { ...res, [e[0]]: e[1] }; | ||
| }, DEFAULT_CONFIG), |
There was a problem hiding this comment.
Instead of using the DEFAULT_CONFIG here, I would use CONFIG, in this way the promo config sheet can have only the fields that need to be overwritten (other config params will be copied from the main config).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.