Update main branch with e2e #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android-dev-lxl
approved these changes
Sep 23, 2023
the-scrambler
force-pushed
the
main-e2e
branch
from
c6b2b67
to
d1ae44d
Compare
johnshea
requested changes
Sep 27, 2023
johnshea
approved these changes
Sep 29, 2023
johnshea
requested changes
Oct 23, 2023
| @@ -46,12 +54,12 @@ class MainActivity : ComponentActivity() { | |||
|
|
|||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
| enableEdgeToEdge() | |||
There was a problem hiding this comment.
This should be before the super.onCreate() call.
| Surface( | ||
| modifier = Modifier.fillMaxSize(), | ||
| color = MaterialTheme.colorScheme.background | ||
| modifier = Modifier |
There was a problem hiding this comment.
This should be one line and not wrap.
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> |
There was a problem hiding this comment.
Why is branch starter-e2e (has it) and this branch (doesn't have it) different regarding <monochrome android:drawable="@drawable/ic_launcher_foreground" />?
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> |
There was a problem hiding this comment.
Why is branch starter-e2e (has it) and this branch (doesn't have it) different regarding <monochrome android:drawable="@drawable/ic_launcher_foreground" />?
There was a problem hiding this comment.
Is there a reason for getting a string resource two different ways 7 lines apart?
nit: It is the same string so possible refactor into one call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.