Fix value for random seed if input seed parameter #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vezhnick
previously approved these changes
Oct 22, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
-- d010a62 by Pragma <[email protected]>: Modified setting of random seed for modules COPYBARA_INTEGRATE_REVIEW=#101 from pragmaticTNT:main 8507f1a PiperOrigin-RevId: 688535463 Change-Id: Id25cf807f48955dcccb394712a4dda7d1853af8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many modules have a private
_seedparameter. Currently, when initializing with aseedparameter,_seedis set to the logical or of this value and a pseudorandom string. Instead, I believe that the intended behaviour is to set_seedtoseedand only generate the pseudorandom string ifseedis null.