Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AndroidEnvConfig. #199

Closed
wants to merge 0 commits into from
Closed

Introduce AndroidEnvConfig. #199

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Introduce AndroidEnvConfig.

This change introduces AndroidEnvConfig, the topmost dataclass to configure
AndroidEnv's instantiation. This aligns the interface used in the open-source
version with Google's internal version.

The main diffs are in loader.py and loader_test.py, with two significant
differences:

  • No automagic param manipulation for connecting to existing emulators.
    • Instead of trying to guess what clients want, loader.load() now just
      interprets the given settings, including the Emulator's console port and
      adb port. This is less error-prone and much simpler to use.
  • loader.load() now supports loading AndroidEnv with a FakeSimulator.
    • This is very convenient when setting up AndroidEnv in a more complex
      infrastructure since FakeSimulator boots up instantaneously.

@copybara-service copybara-service bot force-pushed the test_605303997 branch 7 times, most recently from b3412e3 to 2636392 Compare February 8, 2024 21:28
@copybara-service copybara-service bot closed this Feb 8, 2024
@copybara-service copybara-service bot deleted the test_605303997 branch February 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants