ARCore Extensions for AR Foundation v1.17.0

google-ar · May 14, 2020 · 3be2b4e · 3be2b4e
1 parent cda9970
commit 3be2b4e
Show file tree

Hide file tree

Showing 57 changed files with 139 additions and 67 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,24 +1,37 @@
 # How to Contribute
 
-Please use the [issue tracker](//github.com/google-ar/arcore-unity-extensions/issues)
-to report any issue as we do not accept pull requests for this repository.
+Please use the [issue tracker](https://github.com/google-ar/arcore-unity-extensions/issues)
+to report any bugs or request specific features.
+
+We are happy to review your pull requests.
+
+Follow these steps to contribute changes.
+
+1. Sign our Contributor License Agreement (see below).
+2. Submit a pull request on GitHub.
+
+Here's how your pull request is processed.
+
+3. We will review your changes and leave comments on the pull request.
+4. If accepted, we will merge it into our internal repo and tag the pull request with the "fixed in an upcoming release" label.
+5. After the new version is released, we will close the pull request.
+6. Your change will appear in a future release.
 
-If you'd like to send us a patch or pull request, there are just a few small
-guidelines you need to follow.
 
 ## Contributor License Agreement
 
 Contributions to this project must be accompanied by a Contributor License
-Agreement. You (or your employer) retain the copyright to your contribution;
-this simply gives us permission to use and redistribute your contributions as
-part of the project. Head over to <https://cla.developers.google.com/> to see
-your current agreements on file or to sign a new one.
+Agreement (CLA). You (or your employer) retain the copyright to your
+contribution; this simply gives us permission to use and redistribute your
+contributions as part of the project. Head over to
+<https://cla.developers.google.com/> to see your current agreements on file or
+to sign a new one.
 
 You generally only need to submit a CLA once, so if you've already submitted one
 (even if it was for a different project), you probably don't need to do it
 again.
 
 ## Community Guidelines
 
-This project follows [Google's Open Source Community
-Guidelines](//opensource.google.com/conduct/).
+This project follows
+[Google's Open Source Community Guidelines](https://opensource.google/conduct/).
diff --git a/Editor/BuildResources/ARCoreiOSDependencies.template b/Editor/BuildResources/ARCoreiOSDependencies.template
@@ -1,6 +1,6 @@
 <dependencies>
     <iosPods>
-        <iosPod minTargetSdk="11.0" name="ARCore/CloudAnchors" version="~&gt; 1.16.0">
+        <iosPod minTargetSdk="11.0" name="ARCore/CloudAnchors" version="~&gt; 1.17.0">
             </iosPod>
     </iosPods>
 </dependencies>
diff --git a/Editor/Scripts/Internal/ARCoreAnalytics.cs b/Editor/Scripts/Internal/ARCoreAnalytics.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreAnalytics.cs" company="Google">
+// <copyright file="ARCoreAnalytics.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ARCoreAnalyticsGUI.cs b/Editor/Scripts/Internal/ARCoreAnalyticsGUI.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreAnalyticsGUI.cs" company="Google">
+// <copyright file="ARCoreAnalyticsGUI.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ARCoreAnalyticsProvider.cs b/Editor/Scripts/Internal/ARCoreAnalyticsProvider.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreAnalyticsProvider.cs" company="Google">
+// <copyright file="ARCoreAnalyticsProvider.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ARCoreExtensionsProjectSettings.cs b/Editor/Scripts/Internal/ARCoreExtensionsProjectSettings.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreExtensionsProjectSettings.cs" company="Google">
+// <copyright file="ARCoreExtensionsProjectSettings.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ARCoreExtensionsProjectSettingsGUI.cs b/Editor/Scripts/Internal/ARCoreExtensionsProjectSettingsGUI.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreExtensionsProjectSettingsGUI.cs" company="Google">
+// <copyright file="ARCoreExtensionsProjectSettingsGUI.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ARCoreExtensionsProjectSettingsProvider.cs b/Editor/Scripts/Internal/ARCoreExtensionsProjectSettingsProvider.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreExtensionsProjectSettingsProvider.cs" company="Google">
+// <copyright file="ARCoreExtensionsProjectSettingsProvider.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/Analytics/ArcoreClearcut.cs b/Editor/Scripts/Internal/Analytics/ArcoreClearcut.cs
@@ -1297,11 +1297,11 @@ public enum LogSource {
         /// </summary>
         [pbr::OriginalName("CRONET_SOCIAL")] CronetSocial = 68,
         /// <summary>
-        /// The client side of experiment framework (go/ph, peiling@, phenotype-eng@).
+        /// The client side of experiment framework (go/ph, peiling@, ph-eng@).
         /// </summary>
         [pbr::OriginalName("PHENOTYPE")] Phenotype = 69,
         /// <summary>
-        /// The counters for Phenotype (go/ph, peiling@, phenotype-eng@).
+        /// The counters for Phenotype (go/ph, peiling@, ph-eng@).
         /// </summary>
         [pbr::OriginalName("PHENOTYPE_COUNTERS")] PhenotypeCounters = 70,
         /// <summary>

diff --git a/Editor/Scripts/Internal/AssetHelper.cs b/Editor/Scripts/Internal/AssetHelper.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="AssetHelper.cs" company="Google">
+// <copyright file="AssetHelper.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/CloudAnchorPreprocessBuild.cs b/Editor/Scripts/Internal/CloudAnchorPreprocessBuild.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="CloudAnchorPreprocessBuild.cs" company="Google">
+// <copyright file="CloudAnchorPreprocessBuild.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/IOSSupportHelper.cs b/Editor/Scripts/Internal/IOSSupportHelper.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="IOSSupportHelper.cs" company="Google">
+// <copyright file="IOSSupportHelper.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/IOSSupportPreprocessBuild.cs b/Editor/Scripts/Internal/IOSSupportPreprocessBuild.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="IOSSupportPreprocessBuild.cs" company="Google">
+// <copyright file="IOSSupportPreprocessBuild.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/LogRequestUtils.cs b/Editor/Scripts/Internal/LogRequestUtils.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="LogRequestUtils.cs" company="Google">
+// <copyright file="LogRequestUtils.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/SceneUtils.cs b/Editor/Scripts/Internal/SceneUtils.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="SceneUtils.cs" company="Google">
+// <copyright file="SceneUtils.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Editor/Scripts/Internal/ShellHelper.cs b/Editor/Scripts/Internal/ShellHelper.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ShellHelper.cs" company="Google">
+// <copyright file="ShellHelper.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/README.md b/README.md
@@ -12,6 +12,23 @@ If one or more of those features are required by your project, consider using
 the [ARCore SDK for Unity](//developers.google.com/ar/develop/downloads)
 until those features have been added to this package.
 
+
+## Upcoming breaking change affecting previously published 32-bit-only apps
+
+In **August 2020**, _Google Play Services for AR_ (ARCore) will remove support
+for 32-bit-only ARCore-enabled apps running on 64-bit devices. Support for
+32-bit apps running on 32-bit devices is unaffected.
+
+If you have published a 32-bit-only (`armeabi-v7a`) version of your
+ARCore-enabled app without publishing a corresponding 64-bit (`arm64-v8a`)
+version, you must update your app to include 64-bit native libraries before
+August 2020. 32-bit-only ARCore-enabled apps that are not updated by this time
+may crash when attempting to start an augmented reality (AR) session.
+
+To learn more about this breaking change, and for instructions on how to update
+your app, see https://developers.google.com/ar/64bit.
+
+
 ## Quick Start
 
 See the [Getting Started with ARCore Extensions for Unity](//developers.google.com/ar/develop/unity-arf/quickstart)

diff --git a/Runtime/Plugins/arcore_client.aar b/Runtime/Plugins/arcore_client.aar
diff --git a/Runtime/Plugins/cloud_anchor_manifest.aar b/Runtime/Plugins/cloud_anchor_manifest.aar
diff --git a/Runtime/Plugins/cloud_anchor_manifest.aar.meta b/Runtime/Plugins/cloud_anchor_manifest.aar.meta
diff --git a/Runtime/Scripts/ARAnchorManagerExtensions.cs b/Runtime/Scripts/ARAnchorManagerExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARAnchorManagerExtensions.cs" company="Google">
+// <copyright file="ARAnchorManagerExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/ARCloudAnchor.cs b/Runtime/Scripts/ARCloudAnchor.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCloudAnchor.cs" company="Google">
+// <copyright file="ARCloudAnchor.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //
@@ -135,6 +135,23 @@ public void Update()
             transform.localRotation = m_Pose.rotation;
         }
 
+        /// <summary>
+        /// When the game object containing the ARCloudAnchor component is destroyed, the
+        /// underlying native Cloud Anchor object will be detached and the resource will
+        /// be released.
+        /// </summary>
+        public void OnDestroy()
+        {
+            if (m_AnchorHandle != IntPtr.Zero)
+            {
+                AnchorApi.Detach(
+                    ARCoreExtensions.Instance.CurrentARCoreSessionHandle,
+                    m_AnchorHandle);
+                AnchorApi.Release(m_AnchorHandle);
+                m_AnchorHandle = IntPtr.Zero;
+            }
+        }
+
         internal void SetAnchorHandle(IntPtr anchorHandle)
         {
             m_AnchorHandle = anchorHandle;

diff --git a/Runtime/Scripts/ARCloudReferencePoint.cs b/Runtime/Scripts/ARCloudReferencePoint.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCloudReferencePoint.cs" company="Google">
+// <copyright file="ARCloudReferencePoint.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/ARCoreExtensions.cs b/Runtime/Scripts/ARCoreExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreExtensions.cs" company="Google">
+// <copyright file="ARCoreExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/ARCoreExtensionsConfig.cs b/Runtime/Scripts/ARCoreExtensionsConfig.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARCoreExtensionsConfig.cs" company="Google">
+// <copyright file="ARCoreExtensionsConfig.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/CameraConfigDepthSensorUsages.cs b/Runtime/Scripts/CameraConfigDepthSensorUsages.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="CameraConfigDepthSensorUsages.cs" company="Google">
+// <copyright file="CameraConfigDepthSensorUsages.cs" company="Google LLC">
 //
 // Copyright 2020 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/CloudAnchorState.cs b/Runtime/Scripts/CloudAnchorState.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="CloudAnchorState.cs" company="Google">
+// <copyright file="CloudAnchorState.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/CloudReferenceState.cs b/Runtime/Scripts/CloudReferenceState.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="CloudReferenceState.cs" company="Google">
+// <copyright file="CloudReferenceState.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/ARCoreHandles/ARAnchorExtensions.cs b/Runtime/Scripts/Internal/ARCoreHandles/ARAnchorExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARAnchorExtensions.cs" company="Google">
+// <copyright file="ARAnchorExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/ARCoreHandles/ARPlaneExtensions.cs b/Runtime/Scripts/Internal/ARCoreHandles/ARPlaneExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARPlaneExtensions.cs" company="Google">
+// <copyright file="ARPlaneExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/ARCoreHandles/ARSessionExtensions.cs b/Runtime/Scripts/Internal/ARCoreHandles/ARSessionExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ARSessionExtensions.cs" company="Google">
+// <copyright file="ARSessionExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/ARCoreHandles/XRCameraFrameExtensions.cs b/Runtime/Scripts/Internal/ARCoreHandles/XRCameraFrameExtensions.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="XRCameraFrameExtensions.cs" company="Google">
+// <copyright file="XRCameraFrameExtensions.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/ApiConstants.cs b/Runtime/Scripts/Internal/ApiConstants.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiConstants.cs" company="Google">
+// <copyright file="ApiConstants.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Helpers/DllImportNoop.cs b/Runtime/Scripts/Internal/Helpers/DllImportNoop.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="DllImportNoop.cs" company="Google">
+// <copyright file="DllImportNoop.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Helpers/Translators.cs b/Runtime/Scripts/Internal/Helpers/Translators.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="Translators.cs" company="Google">
+// <copyright file="Translators.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/IOSSupportManager.cs b/Runtime/Scripts/Internal/IOSSupportManager.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="IOSSupportManager.cs" company="Google">
+// <copyright file="IOSSupportManager.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/RuntimeConfig.cs b/Runtime/Scripts/Internal/RuntimeConfig.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="RuntimeConfig.cs" company="Google">
+// <copyright file="RuntimeConfig.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Types/ApiArStatus.cs b/Runtime/Scripts/Internal/Types/ApiArStatus.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiArStatus.cs" company="Google">
+// <copyright file="ApiArStatus.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Types/ApiCloudAnchorMode.cs b/Runtime/Scripts/Internal/Types/ApiCloudAnchorMode.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiCloudAnchorMode.cs" company="Google">
+// <copyright file="ApiCloudAnchorMode.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Types/ApiCloudAnchorState.cs b/Runtime/Scripts/Internal/Types/ApiCloudAnchorState.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiCloudAnchorState.cs" company="Google">
+// <copyright file="ApiCloudAnchorState.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Types/ApiPose.cs b/Runtime/Scripts/Internal/Types/ApiPose.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiPose.cs" company="Google">
+// <copyright file="ApiPose.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //

diff --git a/Runtime/Scripts/Internal/Types/ApiTrackingState.cs b/Runtime/Scripts/Internal/Types/ApiTrackingState.cs
@@ -1,5 +1,5 @@
 //-----------------------------------------------------------------------
-// <copyright file="ApiTrackingState.cs" company="Google">
+// <copyright file="ApiTrackingState.cs" company="Google LLC">
 //
 // Copyright 2019 Google LLC. All Rights Reserved.
 //