Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findInString(where, what string)
function implements a case-insensitive search by converting both strings to lowercase usingstrings.ToLower()
and then using the inbuiltstrings.Index()
function. However, thestrings.ToLower()
function is expensive as it needs to allocate new memory to construct a string.This diff attempts to optimize
findInString()
implementation by avoiding the construction of any new strings in the implementation.The results of the
BenchmarkFormat
test show ~35-40% improvement.Before:
BenchmarkFormat-12 610 1788567 ns/op
After:
BenchmarkFormat-12 880 1336956 ns/op