update to support s3 and avro serialization #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lu-ko review? |
lu-ko
reviewed
Aug 24, 2024
src/lowstorage.ts
Outdated
| }; | ||
|
|
||
| const _hasColName = (colName: string = ''): void => { | ||
| if (colName.trim() === '' || colName === null || typeof colName === 'undefined' || colName.length > 255 || colName === null) { |
There was a problem hiding this comment.
colName === null is checked twice.
src/lowstorage.ts
Outdated
| this._schemas.set(colName, schema); | ||
| } | ||
| } catch (error) { | ||
| throw new SchemaValidationError(`${MODULE_NAME}: Schema is invalid: ${schema}`, lowstorage_ERROR_CODES.SCHEMA_VALIDATION_ERROR); |
There was a problem hiding this comment.
It will be difficult to troubleshoot cause of the problem, if error.message is not logged/passed to SchemaValidationError.
There was a problem hiding this comment.
And, maybe change SchemaValidationError to lowstorageError on this line, to reduce ${MODULE_NAME}: chaining on line nr.241.
There was a problem hiding this comment.
hmmm yes plus if error class has constructor - there is no reason the provider module name on so many places for errors
|
fixed in version 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 integrating pipelines for testing on minio + cloudflare
#13 compatibility w S3 (check https://github.com/sentienhq/ultralight-s3)
#11 adding option to enter some own props like https://github.com/good-lly/lowstorage/tree/v2?tab=readme-ov-file#constructoroptions-s3options / dirPrexif + access to s3