Patch files for github actions in main repo #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to run this repository as a github action as we're doing the github actions 'as is' and essentially just copying the workflow within drone. I've updated the versions of Helm and included the action.yml so that we can include it in the action over in gomods/athens. Also added the shellcheck action as I saw that this was an issue as a part of this repository. Signed-off-by: Chris Mills <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently working on #1638 over in athens and need to be able to follow the exact flow of drone using github actions.
However, as this repository is doing some funky stuff and essentially just pushing stuff to blob storage we need to make it an action to get it working with both drone and github actions and be backwards compatible.
I've basically just made it an action, added shellcheck which fixes #2 and updated a bunch of stuff like the Go version, Helm and the location Helm is being pulled from.
I'd personally do this a bit differently to be honest but we're sticking to an exact replica of the drone configuration so we're not moving too many parts...