Support external tracing deployment (#86)

closes #83
gomods · Sep 26, 2024 · ea30ca7 · ea30ca7
1 parent 4d788c2
commit ea30ca7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/charts/athens-proxy/README.md b/charts/athens-proxy/README.md
@@ -119,6 +119,9 @@ This will deploy a single Athens instance in the `athens` namespace with `disk`
 | strategy.rollingUpdate.maxUnavailable | int | `1` |  |
 | strategy.type | string | `"Recreate"` | Using RollingUpdate requires a shared storage |
 | tolerations | list | `[]` | see https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#scheduling |
+| tracing.enabled | bool | `false` | Set ATHENS_TRACE_EXPORTER* environment variables to point to a tracing deployment. |
+| tracing.type | string | `"jaeger"` | Value of ATHENS_TRACE_EXPORTER, supported values are "jaeger", "datadog", and "stackdriver". |
+| tracing.url | string | `""` | Value of ATHENS_TRACE_EXPORTER_URL |
 | upstreamProxy.enabled | bool | `false` | This is where you can set the URL for the upstream module repository. If 'enabled' is set to true, Athens will try to download modules from the upstream when it doesn't find them in its own storage. Here's a non-exhaustive list of options you can set here:  - https://gocenter.io - https://proxy.golang.org |
 | upstreamProxy.url | string | `"https://gocenter.io"` |  |
 

diff --git a/charts/athens-proxy/templates/deployment.yaml b/charts/athens-proxy/templates/deployment.yaml
@@ -192,6 +192,12 @@ spec:
         - name: ATHENS_TRACE_EXPORTER
           value: "jaeger"
         {{- end }}
+        {{- if and .Values.tracing.enabled (not .Values.jaeger.enabled) }}
+        - name: ATHENS_TRACE_EXPORTER_URL
+          value: {{ .Values.tracing.url }}
+        - name: ATHENS_TRACE_EXPORTER
+          value: {{ .Values.tracing.type }}
+        {{- end }}
         {{- if .Values.basicAuth.enabled }}
         - name: BASIC_AUTH_USER
           valueFrom:

diff --git a/charts/athens-proxy/values.yaml b/charts/athens-proxy/values.yaml
@@ -171,6 +171,14 @@ jaeger:
   # With default settings, it uses the jaeger-collector-http port of the jaeger service.
   url: ""
 
+tracing:
+  # -- Set ATHENS_TRACE_EXPORTER* environment variables to point to a tracing deployment.
+  enabled: false
+  # -- Value of ATHENS_TRACE_EXPORTER_URL
+  url: ""
+  # -- Value of ATHENS_TRACE_EXPORTER, supported values are "jaeger", "datadog", and "stackdriver".
+  type: "jaeger"
+
 # -- Configuration for private git servers that will provide ssh and git config to athens in a ConfigMap
 sshGitServers: []
   ## Private git servers over ssh