Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add H2 test suite. #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add H2 test suite. #256

wants to merge 1 commit into from

Conversation

motlin
Copy link
Collaborator

@motlin motlin commented May 9, 2022 •
edited
Loading

Stacked review of an H2 test suite.

@motlin motlin changed the title Improve error message for invalid database type. Add H2 test suite. May 9, 2022
@motlin motlin marked this pull request as ready for review May 9, 2022 15:46
@mohrezaei
Copy link
Collaborator

I actually meant a test in reladomogenutil. The other test is fine to keep. Sorry I won't be able to take another look at this until tomorrow.

@mohrezaei
Copy link
Collaborator

Please add a test for H2 ddl generation in reladomogenutil. Also rebase.

@motlin
Copy link
Collaborator Author

motlin commented Nov 28, 2022

Sorry for the delay. Looking at this now and I want to check my assumptions. This test would:

  • be a new test
  • execute CoreMithraDbDefinitionGenerator#execute
  • generate into a junit org.junit.rules.TemporaryFolder
  • make assertions about the generated files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motlin @mohrezaei