Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defect for matches when input is null #607

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Fix defect for matches when input is null #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe3a690
Update TCK: 0070-feel-instance-of files
opatrascoiu Nov 16, 2023
21049e9
Update TCK: 1101-feel-floor-function and 1102-feel-ceiling-function f…
opatrascoiu Nov 16, 2023
1d72b9f
Update TCK: 1151-boxed-filter files
opatrascoiu Nov 16, 2023
0d1abf3
Update TCK: 1151-boxed-for files
opatrascoiu Nov 16, 2023
9209c97
Update TCK: 1151-boxed-some files
opatrascoiu Nov 16, 2023
a1f1974
Update TCK: 1151-boxed-every files
opatrascoiu Nov 16, 2023
9de2402
Update TCK: 1111-feel-matches-function files and fix defect.
opatrascoiu Nov 16, 2023
f025cc7
Upgrade antlr to 4.13.1
opatrascoiu Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dmn-core/src/test/java/com/gs/dmn/runtime/interpreter/CL3DMNInterpreterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,11 @@ public void test_14_cl3_100_arithmetic() {
doSingleModelTest("1.4", "0100-arithmetic");
}

@Test
public void test_14_cl3_1111_feel_matches_function() {
doSingleModelTest("1.4", "1111-feel-matches-function");
}

@Test
public void test_14_cl3_1145_feel_context_function() {
doSingleModelTest("1.4", "1145-feel-context-function");
Expand Down
2 changes: 1 addition & 1 deletion dmn-runtime/src/main/java/com/gs/dmn/feel/lib/type/string/DefaultStringLib.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public String replace(String input, String pattern, String replacement, String f
// See https://www.w3.org/TR/xquery-operators/#func-matches
public Boolean matches(String input, String pattern, String flags) throws Exception {
if (input == null || pattern == null) {
return false;
return null;
}
if (flags == null) {
flags = "";
Expand Down
Loading
Loading