Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo resolved - add scope as api parameter carbon.py #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yashv2211
Copy link

I have added the scope as an API parameter in carbon.py and removed the # Todo add scope as API parameter.

I have added the scope as an API parameter and hence removed the # TODO.
I have added Scope as parameter in the API and hence removed the #TODO add scope to parameter comment.
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can contradict with the API contract it have previously.

@Yashv2211
Copy link
Author

Can you suggest how to go about doing the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants