Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove unnecessary init() functions #331

Closed
wants to merge 1 commit into from
Closed

Refactor: remove unnecessary init() functions #331

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Aug 3, 2023 •
edited
Loading

This PR removes init() functions. Calling the init() is considered a bad practice and it's easy to rewrite code in this library.

See https://github.com/leighmcculloch/gochecknoinits and https://peter.bourgon.org/blog/2017/06/09/theory-of-modern-go.html for further reading.

Also, the PR rewrites tests to use httptest.Server with local mux to simplify code.

mfridman
mfridman requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a stylistic change and not something we should change unless there is a very good reason.

@mfridman mfridman closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfridman mfridman mfridman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @mfridman