Update gokr-update-firmware to also pull *.dtbo from overlays #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doridian
commented
Dec 13, 2023
| @@ -54,7 +54,7 @@ jobs: | |||
| BOOTERY_URL: ${{ secrets.BOOTERY_URL }} | |||
| if: ${{ env.GH_USER != 0 }} | |||
| run: | | |||
| if ! gokr-has-label please-merge && ! gokr-has-label please-boot; then go install ./cmd/gokr-update-firmware && gokr-update-firmware && GOPROXY=direct go install github.com/gokrazy/autoupdate/cmd/gokr-amend@latest && gokr-amend -set_label=please-boot *.bin *.elf *.dat; fi | |||
| if ! gokr-has-label please-merge && ! gokr-has-label please-boot; then go install ./cmd/gokr-update-firmware && gokr-update-firmware && GOPROXY=direct go install github.com/gokrazy/autoupdate/cmd/gokr-amend@latest && gokr-amend -set_label=please-boot *.bin *.elf *.dat overlays; fi | |||
There was a problem hiding this comment.
Since rsync -av is used in gokr-amend, this will work perfectly (as -a enables recursion)
stapelberg
approved these changes
Dec 13, 2023
stapelberg
added a commit
that referenced
this pull request
Jun 23, 2024
This reverts commit c96d7de. The overlays files are now shipped with the gokrazy/kernel.rpi repository. related to gokrazy/gokrazy#264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic has been mostly kept the same, but some changes were necessary to avoid duplicating the whole "check and do update" part of the for loop
Paired with gokrazy/tools#67