New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Get, reuse counter value returned by incr operation #5

Open

ankitd009 wants to merge 2 commits into gojekfarm:master from ankitd009:master

ankitd009 commented Aug 11, 2019 •

edited

Loading

Avoid making an extra Get call to read counter's value, use the incremented value returned by INCR operation.

Testing Strategy: existing tests for rate limit should pass.

c.Send("MULTI")
c.Send("INCR", "foo")
c.Send("EXPIRE", "foo", 300)
r, err := c.Do("EXEC")
// prints [1, 1]
// r[0] result of incr operation
// r[1 ] result of expire, 1 if the timeout was set, 0 if key does not exist.
fmt.Println(r)

Redis-Expire Doc
Redigo-Pipeline Doc

ankitd009 added 2 commits

August 11, 2019 19:29


          Remove Get, reuse counter value returned by incr operation

fde21a9


          Update golint import path

4659e92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet