-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Alibaba ACR proxy cache type #19692
base: main
Are you sure you want to change the base?
Conversation
85cdd5a
to
37bf1b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19692 +/- ##
===========================================
+ Coverage 45.36% 66.26% +20.89%
===========================================
Files 244 1047 +803
Lines 13333 114251 +100918
Branches 2719 2847 +128
===========================================
+ Hits 6049 75706 +69657
- Misses 6983 34421 +27438
- Partials 301 4124 +3823
Flags with carried forward coverage won't be shown. Click here to find out more. |
@njucjc could you please share us an account to verify the PR in the Slack |
37bf1b3
to
2851eff
Compare
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
ping @stonezdj @wy65701436 . Any suggestion for this PR? |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
3808dc3
to
aa9e691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Wait for #19658. |
Signed-off-by: njucjc <[email protected]>
Signed-off-by: njucjc <[email protected]>
aa9e691
to
e934130
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #19693
Please indicate you've done the following:
PR for docs #519