Skip to content

Commit

Permalink
Merge pull request #1592 from dsnopek/4.3-revert-unexpose-is-instance…
Browse files Browse the repository at this point in the history
…-valid

[4.3] Revert "Unexpose `UtilityFunctions::is_instance_valid()`"
  • Loading branch information
dsnopek authored Sep 23, 2024
2 parents e298f43 + 17ca325 commit 1cce4d1
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions binding_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -2166,12 +2166,6 @@ def generate_utility_functions(api, output_dir):
header.append("public:")

for function in api["utility_functions"]:
if function["name"] == "is_instance_valid":
# The `is_instance_valid()` function doesn't work as developers expect, and unless used very
# carefully will cause crashes. Instead, developers should use `ObjectDB::get_instance()`
# with object ids to ensure that an instance is still valid.
continue

vararg = "is_vararg" in function and function["is_vararg"]

function_signature = "\t"
Expand Down Expand Up @@ -2206,9 +2200,6 @@ def generate_utility_functions(api, output_dir):
source.append("")

for function in api["utility_functions"]:
if function["name"] == "is_instance_valid":
continue

vararg = "is_vararg" in function and function["is_vararg"]

function_signature = make_signature("UtilityFunctions", function)
Expand Down

0 comments on commit 1cce4d1

Please sign in to comment.