-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wp_safe_remote_get() to retreive remote .ics data #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHerman
requested review from
jrtashjian,
olafleur,
snovosel and
AnthonyLedesma
June 20, 2024 19:59
AnthonyLedesma
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.ics
parser was usingfetch()
to retrieve remote .ics file data. This PR useswp_safe_remote_get()
when retrieving remote .ics file data instead and removes any reference tofetch()
since we do not allow local .ics files to be used.Additional changes to the Ci/CD workflow:
.nvmrc
to 18 to use Node v18 in the workflows@wordpress/env
to 10.1.0@wordpress/scripts
to 28.1.0Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Tested retrieving a remote .ics file from a Github account. (Note: The .ics file must have events in the future, or current day. If they have passed, they will not show up)
Acceptance criteria
Use
wp_safe_remote_get()
instead offetch()
to retrieve remote .ics file data, and ensure things still work as it does in its current state.Checklist: