ok, i think this precedences stuff is finally under control

gobuffalo · Dec 22, 2017 · 6258824 · 6258824
1 parent 43a6d15
commit 6258824
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/if_test.go b/if_test.go
@@ -54,6 +54,14 @@ func Test_Render_If_Or(t *testing.T) {
 	r.Equal("hi", s)
 }
 
+func Test_Render_If_Or_False_False(t *testing.T) {
+	r := require.New(t)
+	input := `<%= if (1 == 2 || 2 == 1) { return "hi" } else { return "bye" } %>`
+	s, err := Render(input, NewContext())
+	r.NoError(err)
+	r.Equal("bye", s)
+}
+
 func Test_Render_If_Nil(t *testing.T) {
 	r := require.New(t)
 	input := `<%= if (names && len(names) >= 1) { %>hi<%} %>`

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -298,6 +298,10 @@ func Test_OperatorPrecedence(t *testing.T) {
 			"foo ~= bar",
 			"(foo ~= bar)",
 		},
+		{
+			"1 != 2 || 2 != 1",
+			"((1 != 2) || (2 != 1))",
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/parser/precedences.go b/parser/precedences.go
@@ -5,6 +5,7 @@ import "github.com/gobuffalo/plush/token"
 const (
 	_           int = iota
 	LOWEST          //
+	ANDOR           // || or &&
 	EQUALS          // ==
 	LESSGREATER     // > or <
 	SUM             // +
@@ -18,8 +19,8 @@ var precedences = map[token.Type]int{
 	token.EQ:       EQUALS,
 	token.NOT_EQ:   EQUALS,
 	token.MATCHES:  EQUALS,
-	token.AND:      EQUALS,
-	token.OR:       EQUALS,
+	token.AND:      ANDOR,
+	token.OR:       ANDOR,
 	token.LT:       LESSGREATER,
 	token.LTEQ:     LESSGREATER,
 	token.GT:       LESSGREATER,