Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from BatEnum to Seq #1437

Open
sim642 opened this issue Apr 30, 2024 · 0 comments · May be fixed by #1443
Open

Switch from BatEnum to Seq #1437

sim642 opened this issue Apr 30, 2024 · 0 comments · May be fixed by #1443
Labels
cleanup Refactoring, clean-up good first issue

Comments

@sim642
Copy link
Member

sim642 commented Apr 30, 2024

In #975 some code was switched from eagerly-constructed lists to the standard Seq.t.
However, there's still many places where BatEnum/Enum is used, which offers similar lazy-sequence functionality.

We could try switching to the more standard Seq.t in those Enum instances, as long as there's no performance regression from doing so.
@sim642 sim642 added cleanup Refactoring, clean-up good first issue labels Apr 30, 2024
@karoliineh karoliineh linked a pull request May 3, 2024 that will close this issue
Draft
3 tasks
@sim642 sim642 linked a pull request May 22, 2024 that will close this issue
Switch from BatEnum to Seq #1443
Draft
3 tasks
@sim642 sim642 mentioned this issue May 22, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Refactoring, clean-up good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from BatEnum to Seq goblint/analyzer
1 participant
@sim642