Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A try on switching to the more standard
Seq.t
inEnum
instances where possible as proposed in #1437Some things that I noticed:
Enum.cartesian_product
is calledproduct
inSeq
Enum.uncombine
is calledunzip
(orsplit
) inSeq
Enum.fold
is calledfold_left
inSeq
Enum.uniq
inSeq
to_seq
inBatHashtbl
to_seq_keys
inBatHashtbl
as in the Ocaml standard libraryHashtbl
TODO
Seq
functions are that new. (Bump OCaml lower bound to 4.14 #1448)