Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3369035: Notification entity conditions can not rely on other template configuration #3437

Merged
merged 1 commit into from
Jun 23, 2023

Commits on Jun 23, 2023

  1. Issue #3369035: Notification entity conditions can not rely on other …

    …template configuration
    
    Entity conditions are executed in ActivityLoggerFactory::createMessages
    before some of the other checks are evaluated. This can cause an entity
    condition that may only be usable on specific bundles to be called on
    other data.
    
    We re-order the checks so that we check for matching properties first
    and only at the end execute the more expensive entity condition plugins.
    This also makes it easier to move the conditions into a database query
    when we move into a different configuration structure in the future.
    Kingdutch committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d1a83d2 View commit details
    Browse the repository at this point in the history