Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Ensure the mail-spool directory exists for Behat tests #3436

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

Kingdutch
Copy link
Member

@Kingdutch Kingdutch commented Jun 23, 2023

Problem / Solution

We previously created this in the GitHub workflow, but this makes new developer project set-up more difficult (because then when running an email test the folder doesn't exist).

By adding it to the repository we ensure it's present for developers and we can remove some steps from the CI.

We rename it from swiftmailer-spool to mail-spool because we know in the future we want to move away from swiftmailer.

We ignore all messages in the directory to make sure we don't accidentally commit debug output.

Issue tracker

Internal no issue

How to test

  • Behat CI should still pass

Definition of done

Before merge

  • Code/peer review is completed
  • All commit messages are clear and clean. If applicable a rebase was performed
  • All automated tests are green
  • Functional/manual tests of the acceptance criteria are approved
  • All acceptance criteria were met
  • New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • This pull request has all required labels (team/type/priority)
  • This pull request has a milestone
  • This pull request has an assignee (if applicable)
  • Any front end changes are tested on all major browsers
  • New UI elements, or changes on UI elements are approved by the design team
  • New features, or feature changes are approved by the product owner

After merge

  • Code is tested on all branches that it has been cherry-picked
  • Update hook number might need adjustment, make sure they have the correct order
  • The Drupal.org ticket(s) are updated according to this pull request status

We previously created this in the GitHub workflow, but this makes new
developer project set-up more difficult (because then when running an
email test the folder doesn't exist).

By adding it to the repository we ensure it's present for developers and
we can remove some steps from the CI.

We rename it from `swiftmailer-spool` to `mail-spool` because we know in
the future we want to move away from swiftmailer.

We ignore all messages in the director to make sure we don't
accidentally commit debug output.
@Kingdutch Kingdutch added team: bananas status: needs review This pull request is waiting for a requested review prio: medium type: repository Improvements to working with the repository (e.g. templates, README files, or workflows) labels Jun 23, 2023
@mergeable
Copy link

mergeable bot commented Jun 23, 2023

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

@Kingdutch Kingdutch merged commit 8a6b79e into main Jun 23, 2023
190 checks passed
@Kingdutch Kingdutch deleted the internal/spool-directory branch June 23, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review type: repository Improvements to working with the repository (e.g. templates, README files, or workflows)
Development

Successfully merging this pull request may close these issues.

1 participant