Allow property types instead of @var annotation in coding standards

goalgorilla · Sep 20, 2021 · 930a328 · 930a328
1 parent d7a5429
commit 930a328
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -53,6 +53,9 @@
                 "Broken title in modal dialog when title is a render array": "https://www.drupal.org/files/issues/2019-10-21/2663316-76.drupal.Broken-title-in-modal-dialog-when-title-is-a-render-array.patch",
                 "PHPDocs with wrong parameters": "https://www.drupal.org/files/issues/2019-09-03/queryinterface-range-updated-phpdocs.patch"
             },
+            "drupal/coder": {
+                "Allow class property types instead of @var comments": "https://www.drupal.org/files/issues/2021-09-20/coder-3123282-2.patch"
+            },
             "drupal/flag": {
                 "Add relationship to flagged entities when Flagging is base table": "https://www.drupal.org/files/issues/2723703_31.patch"
             },

diff --git a/phpcs.xml b/phpcs.xml
@@ -42,15 +42,9 @@
     <!--
       The social_graphql module expects PHP 7.4 but the Drupal coding standards does not yet allow
       nullable class property types. See https://www.drupal.org/project/coder/issues/3191651
-
-      Similarly we ignore missing variable annotation warnings because we use class property types
-      that already contain that information.
     -->
     <rule ref="Squiz.WhiteSpace.OperatorSpacing.NoSpaceAfter">
       <exclude-pattern>./modules/custom/social_graphql/*</exclude-pattern>
     </rule>
-    <rule ref="Drupal.Commenting.VariableComment.MissingVar">
-      <exclude-pattern>./modules/custom/social_graphql/*</exclude-pattern>
-    </rule>
 
 </ruleset>