ci: add linter

.github/workflows/ci.yml

@@ -47,3 +47,19 @@ jobs:
         with:
           name: code-coverage-report
           path: cover.html
+
+  reviewdog:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: lint
+        uses: reviewdog/action-golangci-lint@v2
+        with:
+          go_version_file: go.mod
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-review
+          level: error 
+          filter_mode: nofilter
+          golangci_lint_flags: "--config=.golangci.yml"
+          fail_on_error: true

.golangci.yml

@@ -0,0 +1,22 @@
+linters-settings:
+  govet:
+    enable:
+      - shadow
+
+linters:
+  disable-all: true
+  enable:
+    - staticcheck
+    - gofmt
+    - govet
+    - gocritic
+    - unused
+    - errcheck
+    - gosimple
+    - typecheck
+    - misspell
+    - goimports
+    - gosec
+    - ineffassign
+    - unconvert
+    - unparam

.vscode/settings.json

@@ -17,4 +17,8 @@
             "shadow": true
         }
     },
+    "go.lintTool": "golangci-lint",
+    "go.lintFlags": [
+        "--fast"
+    ],
 }

Makefile

@@ -30,6 +30,10 @@ test_view:
 	rm cover.out.tmp
 	go tool cover -func=cover.out
 	go tool cover -html=cover.out -o cover.html
+lint:
+	golangci-lint run
+lint_diff:
+	golangci-lint run $$(echo $(DIFF_FILE))
 mockgen:
 	go generate ./...
 shadow:

internal/action/action.go

@@ -89,6 +89,7 @@ func CreateFunctionList(input *CreateFunctionListInput) ([][]string, error) {
 	}
 
 	go func() {
+		//nolint:errcheck
 		eg.Wait()
 		close(functionCh)
 	}()

internal/io/input.go

@@ -19,6 +19,7 @@ func GetCheckboxes(label string, opts []string) ([]string, bool) {
 			Options:  opts,
 			PageSize: CheckboxesPageSize,
 		}
+		//nolint:errcheck
 		survey.AskOne(prompt, &checkboxes, survey.WithKeepFilter(true))
 
 		if len(checkboxes) == 0 {

internal/io/output.go

@@ -54,7 +54,9 @@ func outputAsCSV(header []string, data [][]string, csvOutputFilePath string) err
 	outputData = append(outputData, header)
 	outputData = append(outputData, data...)
 
-	w.WriteAll(outputData)
+	if err := w.WriteAll(outputData); err != nil {
+		return err
+	}
 
 	if err := w.Error(); err != nil {
 		return err

pkg/client/lambda.go

@@ -154,13 +154,13 @@ func (c *Lambda) compareActualVersion(first string, second string) (hasFinished
 	secondIntegers := second
 	secondDecimals := ""
 
-	if i := strings.Index(first, "."); i >= 0 {
-		firstIntegers = first[:i]
-		firstDecimals = first[i+1:]
+	if before, after, ok := strings.Cut(first, "."); ok {
+		firstIntegers = before
+		firstDecimals = after
 	}
-	if i := strings.Index(second, "."); i >= 0 {
-		secondIntegers = second[:i]
-		secondDecimals = second[i+1:]
+	if before, after, ok := strings.Cut(second, "."); ok {
+		secondIntegers = before
+		secondDecimals = after
 	}
 
 	if firstIntegers != secondIntegers {

pkg/client/lambda_test.go

@@ -20,6 +20,7 @@ func getNextMarkerForInitialize(
 ) (
 	out middleware.InitializeOutput, metadata middleware.Metadata, err error,
 ) {
+	//nolint:gocritic
 	switch v := in.Parameters.(type) {
 	case *lambda.ListFunctionsInput:
 		ctx = middleware.WithStackValue(ctx, markerKey{}, v.Marker)