Unsubscribe timeout to prevent deadlock (#1) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a timeout to Unsubscribe to prevent deadlock when server does not respond/send receipt * add unsubscribe unit tests to reproduce deadlock * Wait with timeout in Subscription.Unsubscribe => sends an error frame if timeout occurs * Add new error for unsubscribe timeout * Add ConnOpt for unsubscribe timeout
worg
approved these changes
Mar 2, 2024
| @@ -80,7 +83,12 @@ func (s *Subscription) Unsubscribe(opts ...func(*frame.Frame) error) error { | |||
| f.Header.Set(ReplyToHeader, s.id) | |||
| } | |||
|
|
|||
| s.conn.sendFrame(f) | |||
| err := s.conn.sendFrame(f) | |||
| if errors.Is(err, ErrClosedUnexpectedly) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this lib to write a simulator for performance testing, I found out that the library deadlocks if the stomp server does not respond during unsubscribe (e.g. too high load).
The following branch has a test to reproduce the deadlock without the fix applied: https://github.com/maelick/go-stomp/tree/reproduce-unsubscribe-deadlock
This PR is similar to #126 and add a timeout to Unsubscribe to prevent deadlock when the server does not respond/send a receipt.
More specifically it:
The changes are covered with unit tests and I also ensured that my simulator does not deadlock anymore when the server is under high load.