Migrate v2 to using v3 code instead of duplicating it #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7976974605Details
💛 - Coveralls |
paskal
force-pushed
the
paskal/v2_by_v3
branch
2 times, most recently
from
045ee52
to
1025e35
Compare
paskal
force-pushed
the
paskal/v2_by_v3
branch
2 times, most recently
from
ba717b7
to
5003f50
Compare
v2 had most of the required functions, so this change adds missing ones to satisfy the simplelru interface. To do that, RemoveOldest started returning parameters, unlike being void as before. Another behaviour change is that Get and Peek now return the cached value in case it has already expired to be consistent with the `simplelru` implementation. Also, GetExpiration is added.
paskal
force-pushed
the
paskal/v2_by_v3
branch
from
5003f50
to
00002e0
Compare
umputun
reviewed
Feb 20, 2024
| "time" | ||
|
|
||
| v3 "github.com/go-pkgz/expirable-cache/v3" |
There was a problem hiding this comment.
I don't think this is a good idea. First of all, such a dependency feels unnatural and confusing; second - it will bring the v3 package as well as one wanted to include v2. And with vendored deps it will be even more confusing. My vote is to keep them separate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10. Instead of duplicating code, which would be the same in v3, this PR changes v2 to utilize v3, keeping things the same for the user while simplifying code maintenance.