matches now support Regexp objects #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matches function now supports Regexp objects, in case users want to only compile the regex once, before the tests run. Also modified the function to use type switches, making the logic easier to follow
|
Anything? This came up for me today. Not high priority, but would be convenient. |
|
This would fix #94 |
|
It's a bit ironic to say that in a testing project, but we need tests. :) |
|
I think it makes perfect sense -- if your test library isn't tested, how can you be sure it works?
|
|
D'oh. I'll take care of it tonight! |
|
Tests added, though I'd appreciate a manual review to make sure I didn't typo anything |
ashb
reviewed
Dec 5, 2017
checkers.go
Outdated
| if err != nil { | ||
| return false, "Can't compile regex: " + err.Error() | ||
| } else { | ||
| matcher = m |
There was a problem hiding this comment.
Minor style nit: since the if returns the else { isn't needed. (Govent or Golint is built in to my editor and has somewhat ingrained this practice in my head. I don't actually feel strongly about it though)
ashb
approved these changes
Dec 5, 2017
|
Bump? Anything else needed before merge? |
Fixed potential regex compilation bug in matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matches function now supports Regexp objects, in case users want to only compile the regex once, before the tests run.
Also modified the function to use type switches, making the logic easier to follow