closes #1685 #1694
Merged
closes #1685 #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) and was looping until default prcoedure was found. Added a new test in test_widgets and insured handler procedures ware compiled at 'realize' time and not after, as it seem IDL does.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
- Coverage 41.96% 41.95% -0.02%
==========================================
Files 356 356
Lines 95606 95639 +33
Branches 19656 19661 +5
==========================================
Hits 40122 40122
- Misses 55484 55517 +33 ☔ View full report in Codecov by Sentry. |
GillesDuvert
added a commit
to GillesDuvert/gdl
that referenced
this pull request
Jan 8, 2024
…e of gnudatalanguage#1710. Apparently in the case of PLOTMAN, the behaviour of the WIDGET_EVENT loop does not seem to follow the documentation: the event returned by the function is not checked against the hierachy (which is the norm and permits the "rewriting" of events that is the basis of the compound widgets ) but returned immediately. The patch soon proposed will just return if the "modified" event is the same as the event before handling by the function, and it suffices for PLOTMAN. Of course this is far from satisfactory, but as the eventloop of GDL is clearly not the same algorithm as in IDL, especially with the WxWidgets in the middle, this is a point to follow, there may be other cases where a special treatment is needed. test_widgets has now this "test" in the first panel of the "DRAW" tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widget_event was not returning the first catched event (by a function) and was looping until default procedure was found.
Very bad for, e.g., SSW's Plotman graphics.
Added a new test in test_widgets and insured handler procedures ware compiled at 'realize' time and not after, as it seem IDL does.