Save restore procedures now available #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okens will possibly change and the procedures cannot be restored.
…yed while code is active). corrected oops in saverestore, the version code written after the 'normal' end was not always written. Still need to manage better the vector of semiCompiled code (memory leak).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1681 +/- ##
==========================================
+ Coverage 41.80% 41.94% +0.13%
==========================================
Files 356 356
Lines 95211 95616 +405
Branches 19555 19668 +113
==========================================
+ Hits 39805 40102 +297
- Misses 55406 55514 +108 ☔ View full report in Codecov by Sentry. |
… thorough (contains object's procedures and functions)
… case of duplicate names like TIC) prevent to access any internally compiled routine (as the structure members written in C++) as they have no compile dcode associated.
…hey have already been restored. tested on HESSI.
…e and check basic functioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very Good news:
Saves/restore of all procedures (including object procedures) is now in GDL.
Tested on ATV and, more important, SSW's HESSI library of routines.
Despite compression the save files are quite large, larger than their text counterpart. But they are (partially) compiled and the time gain is in favor of using them. As most of the compiled code is a bunch of zeros, there may be a way to improve the compression.
Bad news:
RESOLVE_ALLmust be improved to find all dependencies, otherwise the use of all this is a bit restricted. Note that it is difficult also with IDL to get all needed functions, objects and data within a .sav file.Next step: provide saved (.sav) along our .pro files to speedup GDL.