improved version for GAUSSFIT() + initial import of "test_gaussfit.pro" #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
+ Coverage 41.07% 41.58% +0.51%
==========================================
Files 356 356
Lines 95061 95178 +117
Branches 19539 19556 +17
==========================================
+ Hits 39045 39580 +535
+ Misses 56016 55598 -418 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hum, the c++ code is far from clean & perfect, but it is working now on Linux & OSX and survive to tens of tests incorporated in new "test_gaussfit.pro" code.
I rewrote completely the function which estimated the guess of parameters. It is not perfect but simple and robust when delta_X are more or less constants. It should survive when the steps in X are constants and the quadradic part is not too strong.
Feedback & problematic cases very welcome (in new issues)
Hum, I forgot to removed DEBUG & cout ...