rewrote a more precise tic and toc #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loser to the original; including possibility for (future) report and undocumented features. Incidentally this saves a lot of cpu time and the reported times are now good, i.e., always similar to what would report a construction like x=systime(/sec) & ... do something ... & print,"Time elapsed : ", systime(/sec)-x
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
- Coverage 41.00% 39.85% -1.15%
==========================================
Files 355 355
Lines 95042 95042
Branches 19530 19565 +35
==========================================
- Hits 38968 37882 -1086
- Misses 56074 57160 +1086 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote tic and toc to avoid creating !TICK and more generally stay closer to the original, including existing undocumented features.
Incidentally this saves a lot of cpu time (? why? this needs to be investigated) and the reported times are now good, i.e., always similar to what would report a construction like
x=systime(/sec) & ... do something ... & print,"Time elapsed : ", systime(/sec)-xDoing that I found a bug in resolve_routine that is now corrected by PR #1645. The new tictoc procedures would not work without this PR, and I'm surprized the bug was not reported earlier.
As usual, when writing an equivalent of existing IDL procedures, I stick to the exact same functionalities, no more 'internal help' or 'test' features, that complicate code and possibly make it slower.