Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align 1.0.3 on latest changes #1626

Merged
merged 9 commits into from
Aug 30, 2023
Merged

align 1.0.3 on latest changes #1626

merged 9 commits into from
Aug 30, 2023

Conversation

GillesDuvert
Copy link
Contributor

No description provided.

GillesDuvert and others added 9 commits August 29, 2023 17:57
…olution instead of Eigen::'s.

Added a commandline switch to enable Eigen::Transpose in case this would prove faster on some architectures or after Eigen:: made progresses.
Insured (sort of) that in multithreaded mode, TPOOL_MIN_ELTS is also more or less the number of elements that each thread will process, so that GDL
may use less threads than the machine can provide (some GDL running machines have 64 or more cores). 
Obviously it is not worth starting 128 threads if 10 would already do the job in time.
…hreads used insure each thread will process more or less TPOOL_MIN_ELTS, not a diminutve number given the number of available threads, that can be large, 128 or more.
…hreads used insure each thread will process more or less TPOOL_MIN_ELTS, not a diminutve number given the number of available threads, that can be large, 128 or more.
…ode) use of the max available number of threads, or other variant.
set threshold for codecov PR failures
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 32.25% and project coverage change: -0.02% ⚠️

Comparison is base (907e95f) 41.02% compared to head (759e0ae) 41.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            1.0.3    #1626      +/-   ##
==========================================
- Coverage   41.02%   41.00%   -0.02%     
==========================================
  Files         355      355              
  Lines       95032    95045      +13     
  Branches    19527    19531       +4     
==========================================
- Hits        38987    38974      -13     
- Misses      56045    56071      +26     
Files Changed Coverage Δ
src/basic_fun.cpp 51.41% <ø> (ø)
src/gdl.cpp 59.39% <0.00%> (-1.48%) ⬇️
src/objects.cpp 97.16% <ø> (ø)
src/objects.hpp 66.66% <ø> (ø)
src/basegdl.cpp 6.32% <25.00%> (-0.45%) ⬇️
src/math_fun_jmg.cpp 28.12% <33.33%> (ø)
src/datatypes.cpp 42.24% <57.14%> (-0.70%) ⬇️
src/minmax_include.cpp 36.64% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit ab2b22c into 1.0.3 Aug 30, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants