Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Unable to publish edited posts #268

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

juliopavila
Copy link
Collaborator

Descripción:

This PR addresses the issue reported in #262 where users were unable to publish edited articles due to an indexing loop.

Changes:

  1. Refactored ArticleHeader.tsx:

    • Separated the logic into smaller, more manageable functions for better readability and maintainability.
    • Applied the optimistic UI approach. Once the transaction is successful, users are immediately navigated to the article visualization screen without waiting for indexing in the subgraph. This enhances the user experience as they see immediate results. If users refresh, they will see the updated data.
    • Improved error handling and state management.
  2. Minor changes in usePoster.ts:

    • Added additional logging for better debugging and traceability.

How to Test:

  1. Navigate to a previously created article.
  2. Edit the article.
  3. Click on publish.
  4. The edited article should publish/index correctly without any loops.

Additional Notes:

This solution not only fixes the reported issue but also aims to improve the overall user experience by not making them wait unnecessarily.

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tabula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 4:49pm

@juliopavila juliopavila merged commit 666ff5a into tabula-v.2.1 Oct 17, 2023
4 checks passed
@juliopavila juliopavila deleted the issue-#262 branch October 17, 2023 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant