Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Fix protobuf #13

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix protobuf #13

merged 3 commits into from
Aug 1, 2024

Conversation

kongzii
Copy link
Collaborator

@kongzii kongzii commented Aug 1, 2024

No description provided.

@@ -27,5 +27,6 @@ COPY --from=builder ${VIRTUAL_ENV} ${VIRTUAL_ENV}
COPY predictionprophet_deployment ./predictionprophet_deployment

ENV PYTHONPATH=/app
ENV PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion from library was either this or using a version of protobuf lower than 3.20.x, however due to conflicts, we can do only this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with our docker images that this fixes? The images don't have a c++ compiler?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was

TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your `protos`, some other possible workarounds are:
 1. Downgrade the `protobuf` package to 3.20.x or lower.
 2. Set `PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python` (but this will use pure-Python parsing and will be much slower).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorrryyyy if i'm being slow, could you give a bit more context. When do we see this error? I would have guessed in the build-and-push-image python CD step? looks like they're passing without error though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, this was during the runtime in Kubernetes. This errored out while importing chroma in Python.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh okay. thanks!

@evangriffiths evangriffiths self-requested a review August 1, 2024 09:50
@kongzii kongzii merged commit aba77ad into main Aug 1, 2024
7 checks passed
@kongzii kongzii deleted the peter/fixproto branch August 1, 2024 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants