[client] fix some renderer bugs which cause SPICE display corruption #1121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Side note: Much of the EGL texture code seems to uniquely use a convention of "stride in pixels, pitch in bytes" despite a comment in
texture.h
stating the opposite. The primary source of corruption resolved by this PR (i.e. incorrect pointer math inegl_texBufferStreamUpdate
) is only incorrect because the other EGL texture code follows the opposite convention.