Election export and import as a draft from a json file #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your efforts.
|
mjal
force-pushed
the
mjal/election_export_import
branch
6 times, most recently
from
1aafe98
to
4c3672d
Compare
mjal
changed the title
mjal
changed the title
mjal
force-pushed
the
mjal/election_export_import
branch
3 times, most recently
from
f77bdcf
to
d75fe13
Compare
mjal
commented
Nov 26, 2023
| @@ -19,6 +19,7 @@ | |||
| (* <http://www.gnu.org/licenses/>. *) | |||
| (**************************************************************************) | |||
|
|
|||
| open Js_of_ocaml | |||
There was a problem hiding this comment.
It may be unfortunate to include this here but allows to declare read_full below.
|
This PR is ready. |
mjal
force-pushed
the
mjal/election_export_import
branch
from
d75fe13
to
6e96fd6
Compare
|
A first global comment: we use |
|
Ok! How i18n works ? It seems that Belenios uses Weblate to manage translations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue #65.
It adds a new tab to export an election (or a draft) as json.
The election will be transformed to the draft format.
The file containing the election as json can then be imported to create a new draft with all the necessary informations.