Deprecate Content-Transfer-Encoding per RFC 8951 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Note that the value of this header will still be verified if this header is present, otherwise the absence of this header is silently ignored.
|
Hey @61131 Thanks for submitting this pull request! I just wanted to let you know that I'll assign myself and another dev as reviewers since this seems like a nice change to follow the latest EST standards and I'd be happy to merge this functionality post-review. |
toddgaunt-gs
requested review from
kingcdavid,
laurence-pawling and
toddgaunt-gs
toddgaunt-gs
reviewed
Jan 2, 2024
| errText: "415 Content-Transfer-Encoding must be base64\n", | ||
| }, | ||
| { | ||
| name: "Enroll/MissingContentTransferEncoding", |
There was a problem hiding this comment.
Can we actually keep this test but just change the expected status returned? It'd be nice to have test cases that demonstrate that clients can send nothing at all.
There was a problem hiding this comment.
Nevermind, I see now they are in a function that is explicitly meant to check for errors.
toddgaunt-gs
reviewed
Mar 7, 2024
toddgaunt-gs
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Content-Transfer-Encoding for EST has been deprecated as per RFC 8951. This document identifies that the POST request and payload response of all endpoints use base64 encoding. This format should be used regardless of any Content-Transfer-Encoding header, and any value in such a header MUST be ignored.
This PR removes the requirement for the Content-Transfer-Encoding header in requests and responses and any validation associated with the header if it is present.