Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

Improve filterby #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jpserra
Copy link

@jpserra jpserra commented Dec 16, 2015

Closes #183

@jpserra jpserra force-pushed the improve-filterby branch 8 times, most recently from aedda97 to 2cfcbe6 Compare December 16, 2015 16:36
@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

Having troubled working out the input box for multiple Col:val

@jpserra jpserra force-pushed the improve-filterby branch 5 times, most recently from 38045b8 to edcbe8e Compare December 16, 2015 17:01
@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

This is working properly for programatically set filters (i.e. filterBy={{'Tag': 'new', 'State': 'Alaska'}})
As this is being hard to replicate on the input box, it only allows for 1 col, val combination (i.e. Tag: bacon)

@glittershark
Copy link
Owner

I actually would rather not have the input box parsing here

@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

@glittershark Meaning only programmatically you would be able to achieve this, but keep the input working as is, filtering for all the filterable columns?

@glittershark
Copy link
Owner

yes.

@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

How would you represent the search box upon first render of the table, with filterBy={{Tags: 'new', State: 'alaska'}} ? Show nothing, show Tags: new, State: alaska, etc?

@glittershark
Copy link
Owner

ah, right, didn't think about that. This feature-set can stay as-is then

@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

I'm just gonna rebase it with a small cleanup, let me know what you think afterwards 😉

@jpserra jpserra force-pushed the improve-filterby branch 4 times, most recently from 7ecfa5e to 3a2fad1 Compare December 16, 2015 18:13
@jpserra
Copy link
Author

jpserra commented Dec 16, 2015

Will be waiting for your feedback and suggestion of improvement here, Thank you in advance for taking the time to look into my PR. cheers

This Branch improves the way filterBy workes, by allowing it to be
set with and hash like {'Column': 'search query'} programatically.

Another improvement, that still needs to be touched is the ability to do
the same from the search box in a form of 'Column: search query' that will be
split by the ':' and use each side as column to filter, and value.
@bf
Copy link

bf commented Jan 25, 2017

This one is way overdue.. what is @glittershark doing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants