-
Notifications
You must be signed in to change notification settings - Fork 222
Improve filterby #228
base: master
Are you sure you want to change the base?
Improve filterby #228
Conversation
aedda97
to
2cfcbe6
Compare
Having troubled working out the input box for multiple |
38045b8
to
edcbe8e
Compare
This is working properly for programatically set filters (i.e. |
I actually would rather not have the input box parsing here |
@glittershark Meaning only programmatically you would be able to achieve this, but keep the input working as is, filtering for all the filterable columns? |
yes. |
How would you represent the search box upon first render of the table, with |
ah, right, didn't think about that. This feature-set can stay as-is then |
I'm just gonna rebase it with a small cleanup, let me know what you think afterwards 😉 |
7ecfa5e
to
3a2fad1
Compare
Will be waiting for your feedback and suggestion of improvement here, Thank you in advance for taking the time to look into my PR. cheers |
This Branch improves the way filterBy workes, by allowing it to be set with and hash like {'Column': 'search query'} programatically. Another improvement, that still needs to be touched is the ability to do the same from the search box in a form of 'Column: search query' that will be split by the ':' and use each side as column to filter, and value.
3a2fad1
to
eba3c42
Compare
This one is way overdue.. what is @glittershark doing? |
Closes #183