This repository has been archived by the owner on Jan 15, 2022. It is now read-only.
Add visibleItems() method #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returns an array of data objects that are currently visible, handy to implement item selection / mark as read etc
| const {i, id} = item.props; | ||
| const iOrId = i != null ? i : id; | ||
| const idOrKey = iOrId != null ? iOrId : item.key; | ||
| const data = {id: idOrKey}; |
There was a problem hiding this comment.
I'd prefer to keep these using let
|
Small nit, plus squash these two commits, keep everything squashed to one commit, and rebase, and this is good to go. |
This made it impossible to see if filterBy was provided by the user
…own is not gonna work though, because of the lack of flags
WIL 1240, WIL 1152
it was making devtools unhappy with big datasets
fixed the pagination for empty table
added it to the reactable inputs
encapsulation of the btnPaginators
… If 'topPagination == true' => default filter disabled.
WIL-1502 Kantoor > Delete filter/search box under Medewerker and Service Manager
this way you always can know what is visible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns an array of data objects that are currently visible, handy to implement item selection / mark as read etc.
Simply keep a ref to the table to use it. It uses, in order, the props "i", "id" or the key to allow the user to provide ids for the table rows.
Not sure if the test setup suits your tastes?