Add controlled selection scrolling options #632
Conversation
| * See "Controlled selection" example for details. | ||
| * @group Selection | ||
| */ | ||
| readonly gridSelectionScrollOptions?: GridSelectionScrollOptions; |
There was a problem hiding this comment.
I really like this option, I think we need to workshop the name a bit. Not quite sure I have a better alternative yet... Did you have any other ideas?
There was a problem hiding this comment.
maybe a shorter more generic name like: "gridSelectionScroll" works better.
There was a problem hiding this comment.
focusScrollBehavior focusBehavior gridSelectionBehavior
One of the things about this is it actually only reflects the gridSelection.current.cell
There was a problem hiding this comment.
I prefer gridSelectionBehavior , or gridSelectionScrollBehavior might also be a good choise
There was a problem hiding this comment.
I still need to do an audit of how this interacts with all the other options, would be helpful to break down how this corresponds with the paddingX/Y options etc
There was a problem hiding this comment.
@jassmith anything oustanding on my end for this to get merged?
Added the ability to configure the scrolling when using controlled grid selection.