fix:builds the AMD64 architecture image explicitly and pushes to Airbyte's repo for suing it in Airbyte Cloud #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when trying to setup the destination in Airbyte cloud by explicitly building the amd64 image. I left it also building the arm64 image, but it only pushes am64 to airbytes repo.
We could push the ARM64 image for working with Airbyte OSS locally on arm macs, but this will require one of two approaches:
-arm
postfix on the version tag?Option 1 is the simplest if we care about this.
I also stopped pushing to the Glide-operated Image repo. While Airbyte told us to follow the OSS instructions which included using our own repo, when they enabled the custom docker connectors in Cloud - that ended up forcing us to use a docker image repo managed by them 🤦 So we could tear down that repo in gcloud and clean up the push script to clean this up further.
Let me know if you want me to make those changes or if you'd rather just run with this?