Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:builds the AMD64 architecture image explicitly and pushes to Airbyte's repo for suing it in Airbyte Cloud #13

Merged

Conversation

activescott
Copy link
Collaborator

This fixes the issue when trying to setup the destination in Airbyte cloud by explicitly building the amd64 image. I left it also building the arm64 image, but it only pushes am64 to airbytes repo.

We could push the ARM64 image for working with Airbyte OSS locally on arm macs, but this will require one of two approaches:

  1. Tagging it separately (we could just put an-arm postfix on the version tag?
  2. In theory we could push a multi-architecture image, but since Airbyte builds it separately from pushing and tagging it, we have to use some experimental features in docker wrt manifest.

Option 1 is the simplest if we care about this.

I also stopped pushing to the Glide-operated Image repo. While Airbyte told us to follow the OSS instructions which included using our own repo, when they enabled the custom docker connectors in Cloud - that ended up forcing us to use a docker image repo managed by them 🤦 So we could tear down that repo in gcloud and clean up the push script to clean this up further.

Let me know if you want me to make those changes or if you'd rather just run with this?

…o Airbyte's repo for suing it in Airbyte Cloud
@activescott activescott requested a review from chkn August 6, 2024 19:14
Copy link

@chkn chkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great for now! Probably not worth investing in the multi-arch stuff unless we have specific needs. We can always build the ARM64 image locally, or even just run the AMD64 image directly on Mac using Rosetta.

@activescott activescott merged commit 3b28bb5 into feat/glide-destination Aug 7, 2024
10 checks passed
@activescott activescott deleted the fix/build-amd64-push-to-airbyte-repo branch August 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants