gh-248: fix all remaining possible ruff # noqa statements
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
paddyroddy
commented
Oct 31, 2024
Comment on lines
-194
to
-195
| # TODO(ntessore): missing spin-1 pixel window function here # noqa: FIX002 | ||
| # https://github.com/glass-dev/glass/issues/243 |
There was a problem hiding this comment.
Have just expanded the issue so we can remove FIX002
Saransh-cpp
approved these changes
Nov 5, 2024
ntessore
reviewed
Nov 7, 2024
ntessore
reviewed
Nov 7, 2024
ntessore
reviewed
Nov 7, 2024
ntessore
reviewed
Nov 7, 2024
ntessore
reviewed
Nov 7, 2024
ntessore
reviewed
Nov 7, 2024
glass/points.py
Outdated
Comment on lines
282
to
284
| assert np.sum(n[stop:]) == 0 # noqa: S101 | ||
| if np.sum(n[stop:]) != 0: | ||
| msg = "The number of pixels sampled does not match the expected count." | ||
| raise ValueError(msg) |
There was a problem hiding this comment.
This is also something that can only happen when something is intrinsically broken.
Is S101 really a helpful rule if it flags instances where an assert is definitely the right tool for the job?
There was a problem hiding this comment.
So it's if someone runs python -O in which case asserts will be removed https://docs.astral.sh/ruff/rules/assert
ntessore
reviewed
Nov 7, 2024
|
Have addressed @ntessore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248. Fixing all possible
noqastatements. Leaving those that can't really be fixed, like too many function inputs. I expect some push back on these, so let's iterate.