Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-180: add badges for pre-commit, python versions, discussion, license #251

Merged
merged 2 commits into from
Sep 23, 2024
Merged

gh-180: add badges for pre-commit, python versions, discussion, license #251

merged 2 commits into from
Sep 23, 2024

Conversation

Saransh-cpp
Copy link
Member

Refs: #180

@Saransh-cpp Saransh-cpp added documentation Improvements or additions to documentation maintenance Maintenance: refactoring, typos, etc. labels Sep 19, 2024
ntessore
ntessore requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some badges aren't rendering

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Saransh-cpp
Copy link
Member Author

Oops, my bad! Thanks for pointing out.

@Saransh-cpp Saransh-cpp merged commit c7f12d0 into main Sep 23, 2024
11 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/badges branch September 23, 2024 13:32
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

Assignees

@Saransh-cpp Saransh-cpp

Labels
documentation Improvements or additions to documentation maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @ntessore