ENH: specify bounds for Gaussian photometric redshifts #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntessore
added a commit
that referenced
this pull request
Jul 20, 2023
Fixes a print statement left in #115. Also makes sure this doesn't happen again by adding the `flake8-print` plugin to the pre-commit config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
lower=andupper=keyword parameters to thegaussian_phz()function to sample Gaussian photometric redshifts within the given limits.This currently uses a trivial rejection sampler from the full normal distribution, so it can easily become very inefficient if the bounds don't contain significant probability mass. Needs to be improved for serious use.
Closes: #114
Changed: The
gaussian_phz()function now accepts bounds usinglower=andupper=keyword parameters.