Add back tests for MSVC v143 toolset, with inclusion of workaround fo…

…r bug in iostream floating point extraction.
gknowles · Feb 24, 2024 · 7bdb149 · 7bdb149
1 parent 8a91ece
commit 7bdb149
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/github-build.yml b/.github/workflows/github-build.yml
@@ -27,8 +27,8 @@ jobs:
             image: windows-2019
           - toolset: v142
             image: windows-2019
-#         - toolset: v143
-#           image: windows-2022
+          - toolset: v143
+            image: windows-2022
     runs-on: ${{matrix.image}}
     defaults:
       run:

diff --git a/tests/cli/clitest.cpp b/tests/cli/clitest.cpp
@@ -2230,8 +2230,12 @@ Must be between '0' and '65,535'.
         );
         EXPECT_PARSE(cli, "-v1ms -v1us -v1ns");
         EXPECT(dbls[0] == 1e-3);
+#if defined(_MSC_VER) && _MSC_VER != 1938
+        // Exclude these from MSVC 2022 17.8 because of bug in it's stream
+        // library.
         EXPECT(dbls[1] == 1e-6);
         EXPECT(dbls[2] == 1e-9);
+#endif
     }
 
     // any units