Better usage of args #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really get why wouldn't you want the program to exit if no socks library is aviable? In most cases people use proxies to mask their IP, and if the proxy failed, it would make no sense to continue as it would reveal their IP they are trying to hide. At least it could give the user the option to stop the program before it starts to create the sockets. |
|
Actually, that line isn't in the main repository. It is from my another pull request #82. I was trying to keep those pull requests separate from each other, so I deleted that line from this pr. I'm sorry for misunderstanding. I'm new on Github. |
|
No worries, same goes for me. Thanks for clearing this up for me |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explained in #83