Add ability to send in height or width of the item #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature came from a necessity of having different height items. When that happened, sorting the list would cause discrepancies in size because it was checking the
rowsLayout
with an old height. This helps base the height on something we might already have at the data level. The PR could still benefit from overriding therowsLayout
item itself since it would be more performant aswell to not calculate these values when we already have them but I'm new to the project and I implemented the MVP.Here is an example usage:
The first data item would have a height as the basis and the second would one would be calculated.